feat: wind barbs - #366
Merged
Merged
feat: wind barbs#366
Conversation
Deploying maps with
|
| Latest commit: |
a097988
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a10e7703.maps-5aj.pages.dev |
| Branch Preview URL: | https://windbarbs.maps-5aj.pages.dev |
vincentvdwal
force-pushed
the
windbarbs
branch
from
September 11, 2026 11:56
0ca63a5 to
bc0c2f9
Compare
vincentvdwal
marked this pull request as ready for review
September 11, 2026 11:57
vincentvdwal
force-pushed
the
refactor-variable-selection
branch
from
September 11, 2026 12:11
3f3f94c to
f73637a
Compare
vincentvdwal
added this pull request to stack #390
September 11, 2026 12:18
vincentvdwal
force-pushed
the
windbarbs
branch
from
September 11, 2026 12:26
bc0c2f9 to
89d533a
Compare
vincentvdwal
force-pushed
the
refactor-variable-selection
branch
2 times, most recently
from
September 11, 2026 13:48
a63eeb7 to
b866608
Compare
vincentvdwal
force-pushed
the
windbarbs
branch
from
September 11, 2026 13:48
89d533a to
35494e5
Compare
vincentvdwal
force-pushed
the
refactor-variable-selection
branch
from
September 11, 2026 13:53
b866608 to
f7e6490
Compare
vincentvdwal
force-pushed
the
windbarbs
branch
from
September 11, 2026 13:54
35494e5 to
b513add
Compare
vincentvdwal
removed this pull request from stack #390
September 11, 2026 14:02
vincentvdwal
added this pull request to stack #398
September 11, 2026 14:03
vincentvdwal
force-pushed
the
refactor-variable-selection
branch
from
September 11, 2026 14:04
f7e6490 to
382a960
Compare
vincentvdwal
force-pushed
the
windbarbs
branch
2 times, most recently
from
September 11, 2026 14:11
f6f463c to
ec4f5bf
Compare
vincentvdwal
force-pushed
the
refactor-variable-selection
branch
from
September 11, 2026 14:11
382a960 to
8a4d3e3
Compare
terraputix
force-pushed
the
refactor-variable-selection
branch
from
September 14, 2026 12:08
8a4d3e3 to
d6f81b2
Compare
terraputix
force-pushed
the
windbarbs
branch
from
September 14, 2026 12:08
ec4f5bf to
b1a86f8
Compare
vincentvdwal
force-pushed
the
windbarbs
branch
from
September 16, 2026 10:31
b1a86f8 to
132293e
Compare
vincentvdwal
force-pushed
the
refactor-variable-selection
branch
from
September 16, 2026 10:31
d6f81b2 to
e80bc9a
Compare
vincentvdwal
removed this pull request from stack #398
September 16, 2026 10:32
terraputix
reviewed
Sep 17, 2026
terraputix
left a comment
terraputix
left a comment
Collaborator
There was a problem hiding this comment.
Looks really cool!
I would still prefer to merge this as a separate squashed commit, after #361 has been merged!
And one nitpick: Should the arrow switch to a barb in the popover as well? I fear this would add a lot of custom code to draw the barb for the popover, so it might not be worth it. But it would be nice for consistency!
Member
Author
Yes good idea, let's do that.
I thought about it, and even tried it, but I don't know, it's than much smaller and harder to read. I think the arrow in the popup is fine. Also for the upcoming wind animation it's also showing a arrow, instead of the flow of particles |
vincentvdwal
marked this pull request as draft
September 18, 2026 07:27
vincentvdwal
force-pushed
the
windbarbs
branch
from
September 23, 2026 08:38
2c05e2e to
a097988
Compare
vincentvdwal
marked this pull request as ready for review
September 23, 2026 09:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wind barbs
Adds wind barbs as an alternative to arrows for wind layers.
generated as sprites from the same shape description the tile generator
uses (
arrow-shapes.ts/arrow-sprites.ts)previews and a knots legend, icon scale and packing sliders, and a
wind-rose diagram
selected style